[Multiple Choice Task] Fix UI bugs in multiple choice selectors #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2899 +/- ##
============================================
- Coverage 62.22% 61.90% -0.33%
+ Complexity 1205 1204 -1
============================================
Files 267 268 +1
Lines 6380 6441 +61
Branches 882 897 +15
============================================
+ Hits 3970 3987 +17
- Misses 1863 1898 +35
- Partials 547 556 +9
|
gino-m
requested changes
Dec 5, 2024
anandwana001
reviewed
Dec 6, 2024
|
Marking this as draft. Working towards migrating the task's UI to compose. |
shobhitagarwal1612
force-pushed
the
ashobhit/2893/choice-ux
branch
2 times, most recently
from
2adc6a8 to
459bee0
Compare
|
@gino-m This is now ready for another pass! Migrated the UI to compose and updated styling & unit tests. |
...a/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceItemView.kt
Show resolved
Hide resolved
...a/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceItemView.kt
Show resolved
Hide resolved
...a/com/google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceTestTags.kt
Outdated
Show resolved
Hide resolved
gino-m
requested changes
Dec 23, 2024
.../google/android/ground/ui/datacollection/tasks/multiplechoice/MultipleChoiceTaskViewModel.kt
Show resolved
Hide resolved
gino-m
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2893
Updates UX as per figma mocks
@gino-m PTAL?